Skip to content

Replace variable name from 'query' to 'path' where query was defined as a full path(#259) #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 26, 2022

Conversation

Dishant10
Copy link
Contributor

Pull Request

Related issue

Fixes #259

What does this PR do?

Fixes the issue where a variable name 'query' was set to a full path value. As the issue mentioned the variable name 'path' would be more suitable in this situation. So this PR changes all the variable query whose values were actually a path.

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • [ • ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ • ] Have you read the contributing guidelines?
  • [ • ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali
brunoocasali previously approved these changes Oct 26, 2022
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution to Meilisearch @Dishant10 ❤️

@brunoocasali
Copy link
Member

@Dishant10 apparently, your code does not matches our linter rules, can you check that?

@brunoocasali brunoocasali added the enhancement New feature or request label Oct 26, 2022
@Dishant10
Copy link
Contributor Author

Sure! I'll take a look at that.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution to Meilisearch ❤️

bors merge

@Dishant10
Copy link
Contributor Author

I read the CONTRIBUTING.md for the linter issues. Should I run this command?
swift run swiftlint --fix
I don't have much knowledge about linter/linting.

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 26, 2022

@meili-bors meili-bors bot merged commit d77a54d into meilisearch:main Oct 26, 2022
@brunoocasali
Copy link
Member

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change naming of API path variable from query to path
2 participants