-
Notifications
You must be signed in to change notification settings - Fork 26
Replace variable name from 'query' to 'path' where query was defined as a full path(#259) #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution to Meilisearch @Dishant10 ❤️
@Dishant10 apparently, your code does not matches our linter rules, can you check that? |
Sure! I'll take a look at that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution to Meilisearch ❤️
bors merge
I read the CONTRIBUTING.md for the linter issues. Should I run this command? |
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
Pull Request
Related issue
Fixes #259
What does this PR do?
Fixes the issue where a variable name 'query' was set to a full path value. As the issue mentioned the variable name 'path' would be more suitable in this situation. So this PR changes all the variable query whose values were actually a path.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!