Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature for clients that do not implement send #579

Merged
merged 3 commits into from
May 2, 2024

Conversation

ezegros
Copy link
Contributor

@ezegros ezegros commented May 2, 2024

Pull Request

Related issue

Fixes #577

What does this PR do?

Some clients do not have Send compatible futures. To fix this I propose adding a feature disabled by default to support this kind of clients like acw, Send should be supported by default.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@irevoire irevoire added the bug Something isn't working label May 2, 2024
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ezegrosfeld, thanks a lot for your contribution.

It’s exactly what I was looking for!

bors merge

Copy link
Contributor

meili-bors bot commented May 2, 2024

@meili-bors meili-bors bot merged commit 993f044 into meilisearch:main May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement std::marker::Send for SearchResults
2 participants