Skip to content

Commit 872777e

Browse files
bors[bot]sanders41
andauthored
Merge #117
117: Remove dollar signs from code examples r=curquiza a=sanders41 Relates to meilisearch/integration-guides#99 Relates to meilisearch/integration-guides#103 Co-authored-by: Paul Sanders <psanders1@gmail.com>
2 parents 42a0ae2 + 1e3f090 commit 872777e

File tree

5 files changed

+20
-19
lines changed

5 files changed

+20
-19
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
/target
22
Cargo.lock
33
examples/web_app/target/*
4+
.vscode

CONTRIBUTING.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ To run the tests one by one, run:
3939

4040
```bash
4141
# Tests
42-
$ docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
43-
$ docker run -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics=true
44-
$ cargo test -- --test-threads=1
42+
docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
43+
docker run -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics=true
44+
cargo test -- --test-threads=1
4545
```
4646

4747
Each PR should pass the tests to be accepted.
@@ -51,20 +51,20 @@ Each PR should pass the tests to be accepted.
5151
Each PR should pass [`clippy`](https://github.com/rust-lang/rust-clippy) (the linter) to be accepted.
5252

5353
```bash
54-
$ cargo clippy -- -D warnings
54+
cargo clippy -- -D warnings
5555
```
5656

5757
If you don't have `clippy` installed on your machine yet, run:
5858

5959
```bash
60-
$ rustup update
61-
$ rustup component add clippy
60+
rustup update
61+
rustup component add clippy
6262
```
6363

6464
⚠️ Also, if you have installed `clippy` a long time ago, you might need to update it:
6565

6666
```bash
67-
$ rustup update
67+
rustup update
6868
```
6969

7070
### Update the README
@@ -74,17 +74,17 @@ The README is generated. Please do not update manually the `README.md` file.
7474
Instead, update the `README.tpl` and `src/lib.rs` files, and run:
7575

7676
```sh
77-
$ sh scripts/update-readme.sh
77+
sh scripts/update-readme.sh
7878
```
7979

8080
Then, add the generated `README.md` file to your git commit.
8181

8282
You can check the current `README.md` is up-to-date by running:
8383

8484
```sh
85-
$ sh scripts/check-readme.sh
85+
sh scripts/check-readme.sh
8686
# To see the diff
87-
$ sh scripts/check-readme.sh --diff
87+
sh scripts/check-readme.sh --diff
8888
```
8989

9090
If it's not, the CI will fail on your PR.
@@ -151,7 +151,7 @@ with the right version.
151151
You should run the following command after the changes applied to `lib.rs`:
152152

153153
```bash
154-
$ sh scripts/update-readme.sh
154+
sh scripts/update-readme.sh
155155
```
156156

157157
Also, you might need to change the [code-samples file](/.code-samples.meilisearch.yaml) if the minor has been upgraded:

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ There are many easy ways to [download and run a MeiliSearch instance](https://do
7171

7272
For example, if you use Docker:
7373
```bash
74-
$ docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
75-
$ docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey
74+
docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
75+
docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey
7676
```
7777

7878
NB: you can also download MeiliSearch from **Homebrew** or **APT**.

examples/web_app/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ The Rust source files are compiled into WebAssembly and so can be readable by th
1111
If you only want to check if this example compiles, you can run:
1212

1313
```console
14-
$ cargo build --example web_app
14+
cargo build --example web_app
1515
```
1616

1717
## Building
1818

1919
To build this example, you need [wasm-pack](https://github.com/rustwasm/wasm-pack).\
2020
You can install `wasm-pack` with this command:
2121
```console
22-
$ curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
22+
curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
2323
```
2424

2525
```console
26-
$ wasm-pack build examples/web_app/ --target=web --no-typescript
26+
wasm-pack build examples/web_app/ --target=web --no-typescript
2727
```
2828

2929
The compiled files will be stored in the `examples/web_app/pkg` folder.
@@ -33,7 +33,7 @@ The compiled files will be stored in the `examples/web_app/pkg` folder.
3333
Theoretically, you could just open the `examples/web_app/pkg/index.html` file but due to browsers' security restrictions, you need a web server. For example:
3434

3535
```console
36-
$ python3 -m http.server 8080
36+
python3 -m http.server 8080
3737
```
3838

3939
And then go to the `http://localhost:8080/` URL in your browser.

src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
//!
2727
//! For example, if you use Docker:
2828
//! ```bash
29-
//! $ docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
30-
//! $ docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey
29+
//! docker pull getmeili/meilisearch:latest # Fetch the latest version of MeiliSearch image from Docker Hub
30+
//! docker run -it --rm -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey
3131
//! ```
3232
//!
3333
//! NB: you can also download MeiliSearch from **Homebrew** or **APT**.

0 commit comments

Comments
 (0)