Fix bug: Search optional params are not applied when they are a list of strings #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a search parameter like
attributesToHighlight
orattributesToRetrieve
are given as a list of strings, they should be encoded as a comma separated string into the url:should become
This encoding is not the default behaviour of the url lib encoding and it was introducing the
[
and]
characters in the url (and some+
) so MeiliSearch was ignoring those parameters.Before encoding this parameters, I added a few lines:
this will transform the lists of strings in the expected format.
A test was added to the
meilisearch/tests/index/test_index_document_meilisearch.py
file to check this behaviorCloses #85