Refactor the library #557
Merged
Refactor the library #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
556: Refactor meilisearch client wtih new client and documentation r=curquiza a=Ja7ad # Pull Request ## Related issue Resolves #554, resolves #462 ## What does this PR do? - Refactor client to http.Client with optimized configuration - Support parent context for all methods - Add option pattern for optional configuration of constructor - Improved documentation package, methods - This refactor make better experience usage sdk for developers. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Javad <ja7ad@live.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 86.92% 86.79% -0.13%
==========================================
Files 11 11
Lines 1629 1856 +227
==========================================
+ Hits 1416 1611 +195
- Misses 113 152 +39
+ Partials 100 93 -7 ☔ View full report in Codecov by Sentry. |
curquiza
added
the
breaking-change
This was
linked to
issues
Aug 14, 2024
Ja7ad
approved these changes
Aug 14, 2024
curquiza
added
skip-changelog
curquiza
added
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.