Add tooltips for menucard buttons, fixes #76

bergie · bergie · commit 0b85f6f7e477 · 2013-10-02T16:19:02.000+02:00
diff --git a/build/dataflow.build.js b/build/dataflow.build.js
@@ -1,4 +1,4 @@
-/*! dataflow.js - v0.0.7 - 2013-10-02 (4:12:33 PM GMT+0200)
+/*! dataflow.js - v0.0.7 - 2013-10-02 (4:18:28 PM GMT+0200)
 * Copyright (c) 2013 Forrest Oliphant; Licensed MIT, GPL */
 (function(){
   var App = Backbone.Model.extend({
@@ -152,7 +152,7 @@
         this.plugins.menu.addPlugin({
           id: info.id,
           icon: info.icon,
-          label: info.name,
+          label: info.label,
           showLabel: false
         });
       }
@@ -2739,7 +2739,7 @@
 
   var MenuItemView = Backbone.View.extend({
     tagName: 'li',
-    template: '<button><i class="icon-<%- icon %>"></i><span class="name"><%- label %></span></button>',
+    template: '<button title="<%- label %>"><i class="icon-<%- icon %>"></i><span class="name"><%- label %></span></button>',
     events: {
       'click': 'clicked'
     },
@@ -2951,7 +2951,7 @@
       Menu.card.menu.add({
         id: info.id,
         icon: info.icon,
-        label: info.name,
+        label: info.label,
         showLabel: false,
         action: function () {
           Menu.card.hide();
@@ -3303,6 +3303,7 @@
 
     dataflow.addPlugin({
       id: "library", 
+      label: "library",
       name: "", 
       menu: $container, 
       icon: "plus",
@@ -3357,6 +3358,7 @@
 
     dataflow.addPlugin({
       id: "source", 
+      label: "view source",
       name: "", 
       menu: $form, 
       icon: "code",
@@ -3446,6 +3448,7 @@
 
     dataflow.addPlugin({
       id: "log", 
+      label: "log",
       name: "", 
       menu: $log, 
       icon: "th-list",
diff --git a/build/dataflow.min.js b/build/dataflow.min.js
diff --git a/build/dataflow.min.js.map b/build/dataflow.min.js.map
diff --git a/src/dataflow.js b/src/dataflow.js
@@ -150,7 +150,7 @@
         this.plugins.menu.addPlugin({
           id: info.id,
           icon: info.icon,
-          label: info.name,
+          label: info.label,
           showLabel: false
         });
       }
diff --git a/src/modules/menucard-view.js b/src/modules/menucard-view.js
@@ -4,7 +4,7 @@
 
   var MenuItemView = Backbone.View.extend({
     tagName: 'li',
-    template: '<button><i class="icon-<%- icon %>"></i><span class="name"><%- label %></span></button>',
+    template: '<button title="<%- label %>"><i class="icon-<%- icon %>"></i><span class="name"><%- label %></span></button>',
     events: {
       'click': 'clicked'
     },
diff --git a/src/plugins/library.js b/src/plugins/library.js
@@ -88,6 +88,7 @@
 
     dataflow.addPlugin({
       id: "library", 
+      label: "library",
       name: "", 
       menu: $container, 
       icon: "plus",
diff --git a/src/plugins/log.js b/src/plugins/log.js
@@ -12,6 +12,7 @@
 
     dataflow.addPlugin({
       id: "log", 
+      label: "log",
       name: "", 
       menu: $log, 
       icon: "th-list",
diff --git a/src/plugins/menu.js b/src/plugins/menu.js
@@ -15,7 +15,7 @@
       Menu.card.menu.add({
         id: info.id,
         icon: info.icon,
-        label: info.name,
+        label: info.label,
         showLabel: false,
         action: function () {
           Menu.card.hide();
diff --git a/src/plugins/view-source.js b/src/plugins/view-source.js
@@ -18,6 +18,7 @@
 
     dataflow.addPlugin({
       id: "source", 
+      label: "view source",
       name: "", 
       menu: $form, 
       icon: "code",

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@`
`150`	`150`	`this.plugins.menu.addPlugin({`
`151`	`151`	`id: info.id,`
`152`	`152`	`icon: info.icon,`
`153`		`- label: info.name,`
	`153`	`+ label: info.label,`
`154`	`154`	`showLabel: false`
`155`	`155`	`});`
`156`	`156`	`}`