Skip to content

Commit 54a2842

Browse files
committed
- Fixed Windows detection
- Added note about using nvarchar
1 parent dd369d1 commit 54a2842

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Helper/PlatformHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ class PlatformHelper
99
*/
1010
public static function isWindows()
1111
{
12-
return stristr(PHP_OS, 'WIN');
12+
return stristr(PHP_OS, 'WIN') && strtolower(PHP_OS) !== 'darwin';
1313
}
1414
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ There are a few bundles and packages out there which can handle dblib but unfort
3232
- Support for ORM requires modifications to some Doctrine files in the vendor folder, a script for Composer which does this automatically is provided in this bundle
3333
- When doing manual queries you should always use executeQuery() and executeUpdate() on Doctrine DBAL
3434
- Named parameters are not supported, UTF-8 characters will be saved as ?
35-
- This bundle was only tested on SQL Server 2008 R2 SP2
35+
- This bundle was only tested on SQL Server 2008 R2 SP2 and nvarchar fields
3636
- Joined inheritance mapping in ORM is not supported yet since we did not need it, this might be supported in the future
3737
- Symfony session handler does not use locking now, this might be supported in the future
3838
- There are no tests since original tests on Doctrine are also likely to fail, take this bundle as-is but please create a PR if you have found an issue and fixed it

0 commit comments

Comments
 (0)