Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visuallyhidden class further #161

Open
anselmh opened this issue Aug 23, 2017 · 4 comments
Open

Improve visuallyhidden class further #161

anselmh opened this issue Aug 23, 2017 · 4 comments

Comments

@anselmh
Copy link

anselmh commented Aug 23, 2017

The HTML5Boilerplate team has recently improved the .visuallyhidden class to fix issues with Voice Over. The changes are in https://github.com/h5bp/html5-boilerplate/pull/1989/files.

Maybe you want to incorporate these changes as well on https://allyjs.io/tutorials/hiding-elements.html#2017-edition-of-visuallyhidden as I saw you updated the code snippet with a quite nice selector chain now?

@rodneyrehm
Copy link
Member

Thanks for bringing this to my attention! I just read through h5bp/html5-boilerplate#1985 to understand the change and noticed that they reverted the change 3 days ago, as this was causing visual problems.

@anselmh
Copy link
Author

anselmh commented Aug 23, 2017

Oh, heh, thanks for reporting that back! Well then it’s probably not the best idea to change the code.

@cedeber
Copy link

cedeber commented Dec 4, 2017

I didn't test it with Voice Over, but on IE 11 if a visually hidden element is a flexbox child it is rendered. I mean, you don't see it but it takes space. I fix it by adding flex: 0 0 0 to the class.

@cedeber
Copy link

cedeber commented Dec 4, 2017

Ok, I test it again and the flex solution doesn't work. The magic of IE debugger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants