Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize setup.py & requirements.txt #74

Open
boogheta opened this issue Mar 11, 2021 · 4 comments
Open

Uniformize setup.py & requirements.txt #74

boogheta opened this issue Mar 11, 2021 · 4 comments

Comments

@boogheta
Copy link
Member

Instead of maintaining two distinct list of dependencies, it would be best if either we got rid of requirements.txt, or if setup.py would rely on its content

@Yomguithereal
Copy link
Member

Unfortunately without using something like poetry this is not as easy as it seems, especially if you need to have a difference between regular and dev dependencies and need strict deps when developing but allowing more relaxed one on the setup.py file... python's gonna python I guess

@boogheta
Copy link
Member Author

Couldn't we have only dev dependencies in a separate requirements file for instance?

@Yomguithereal
Copy link
Member

Then you need to have some kind of custom install script not to force your user to run pip install on two requirements file when developing? My point is le jeu n'en vaut peut-être pas la chandelle vs. maintenir requirements.txt + setup.py de manière parallèle :)

@boogheta
Copy link
Member Author

I'm split :p
Otherwise I have a "fantastic" idea! Let's add a github action that checks the consistency on each commit and fixes it whenever we forget! OK I'm leaving...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants