feat: Add new migration for DVO Cook'n #5085
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
This pull request adds the functionality of being able to import cookbooks from DVO Cook'n X3 (it might also work with newer or older version, but I am unable to test that).
File changes:
Notes:
This directly supports ingredient amounts. To do this I have imported all ingredients and foods used from the Cook'n library (duplicates are hopefully mitigated by using the fuzzy matching in DataMatcher).
Special notes for your reviewer:
(fill-in or delete this section)
Focus should primarily be on mealie/services/migrations/cookn.py. As 95% of the changes are in that file. Functionally the code should be pretty good, but formatting, code consistency, and documentation might need some touch ups.
P.S. This is my first time working with strict typing, vue, and docker. So apologies up front if I am missing anything.
Testing
(fill-in or delete this section)
I have tested it with all my recipes from Cook'n (about 750). Doing a spot check everything seems to be in order. The included test only has 3 recipes, but I can update it with more if needed.
I also ran py:check with the following pytest results: