Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Shopping List does not consider "on hand" when doubling recipe (v2.0.0) #4547

Open
5 of 6 tasks
alexxxxxxxandria opened this issue Nov 12, 2024 · 0 comments
Open
5 of 6 tasks
Labels
bug: confirmed bug Something isn't working

Comments

@alexxxxxxxandria
Copy link
Contributor

alexxxxxxxandria commented Nov 12, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When you add a recipe to the shopping list, the recipe appears at the bottom of the list and has the option to be doubled/tripled/etc. Using this feature will add the entire list of ingredients to the shopping list, even ingredients that are marked as "on hand" and were successfully identified as unnecessary during the original "add to shopping list" step.

Steps to Reproduce

Prerequisites

  • Have some ingredients that are on hand
  • Have a recipe that includes some on-hand ingredients

Steps

  1. Add the recipe to the shopping list
    • Note that by default, not all ingredients are checked because some are "on hand"
  2. Review the shopping list. Note that only the checked items appear.
    • Possibly notable: I checked off/delete other ingredients from other recipes before the next step
  3. At the bottom of the shopping list page, find the recipe you added ingredients for
  4. Select the + button to double the recipe
  5. Notice that all ingredients have been added to the list, even items that are still "on hand"

Please provide relevant logs

Browser

Console

No browser console logs are generated.

Network

POST /api/households/shopping/lists/38a359dd-84a6-4f15-9c41-9e563a3a9cc5/recipe/a3fa7e88-0991-4ae5-9bfb-697854ef8ab0

{
    "recipeIncrementQuantity": 1,
    "recipeIngredients": null
}

Docker

mealie             | INFO     2024-11-12T10:37:44 - [10.11.12.13:0] 200 OK "POST /api/households/shopping/lists/38a359dd-84a6-4f15-9c41-9e563a3a9cc5/recipe/a3fa7e88-0991-4ae5-9bfb-697854ef8ab0 HTTP/1.1"
mealie             | INFO     2024-11-12T10:37:44 - [10.11.12.13:0] 200 OK "GET /api/households/shopping/lists/38a359dd-84a6-4f15-9c41-9e563a3a9cc5 HTTP/1.1"

Mealie Version

Docker

ghcr.io/mealie-recipes/mealie:v2.0.0@sha256:332a3b04567cc4818238792807485913692b54b3cc5d7d7b24fae3262210df14

UI

Build
a7c8b33cca37882f687a0528f93631545de74f1d

Deployment

Docker (Linux)

Additional Deployment Details

No response

@alexxxxxxxandria alexxxxxxxandria added bug Something isn't working triage labels Nov 12, 2024
@alexxxxxxxandria alexxxxxxxandria changed the title [BUG] - Shopping List does not consider "on hand" when doubling recipe (v2.1.0) [BUG] - Shopping List does not consider "on hand" when doubling recipe (v2.0.0) Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants