Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - When entering an invalid (non-numeric?) quantity for an ingredient, on mobile (PWA), quantity isn't stored #2926

Open
6 tasks done
boc-the-git opened this issue Jan 8, 2024 · 4 comments
Labels
bug: confirmed bug Something isn't working

Comments

@boc-the-git
Copy link
Collaborator

boc-the-git commented Jan 8, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When entering an ingredient quantity such as 1-4, on mobile (both PWA and Chrome browser, on Android), you see 1-4 in the quantity field and everything looks fine. When you save the recipe, NO quantity value is stored.

(This is not a problem on desktop, which stops me entering the - in the first place.. if I type 1-4 on the keyboard, only 14 enters the field)

Not tested on iOS. Assume to be the same, but not sure.

Steps to Reproduce

  1. On Android, in PWA or browser (Chrome tested), edit a recipe
  2. Set the quantity of an ingredient to 1-4 (or similar)
  3. Save recipe
  4. Quantity becomes null (even if there was a previously valid quantity such as 1)

Please provide relevant logs

Nothing in the Mealie logs, shows a successful PUT with nothing extra.

Mealie Version

Details
Version: nightly
Build: 7222abe
Application Mode: Production
Demo Status: Not Demo
API Port: 9000
API Docs: Enabled
Database Type: sqlite
Recipe Scraper Version: 14.53.0

Checks
Secure Site: Yes
Server Side Base URL: Yes
LDAP Ready: No
Email Configured: Yes

Deployment

Docker (Linux)

Additional Deployment Details

No response

@boc-the-git boc-the-git added bug Something isn't working triage labels Jan 8, 2024
@boc-the-git
Copy link
Collaborator Author

My guess is this is either because 1-4 gets evaluated as maths, becoming -3 or more likely because it's an invalid character - but nothing is reported to the Android user.

I'm not planning on immediately investigating this myself because I consider it a low priority.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 14, 2024
@boc-the-git
Copy link
Collaborator Author

I still care about this

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants