printf() can not handle a argument of type va_list. #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @BlueAndi !! |
In at least two places in the code, the response object is evaluated on whether it has finished sending data to the client. If the response has already finished, or enters the finished state after sending data, the underlying socket should not be left open. Failure to close the socket in these scenarios cause the remote client to timeout expecting more data unless it closes the connection on its own. Fixes: me-no-dev#802
…finished-pull-try1 Explicitly close socket after response has entered finished state
Fix duplicated number of fragmented frames
…r appeared in case it was defined in the platformio.ini
Preparation for arduino 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix is for AsyncWebSocket::printf() and AsyncWebSocket::printf_P().
#695
#56