Skip to content

Commit b598aed

Browse files
ssaakianStykMartin
authored andcommitted
Fix compatibility: Honor six import for xmlrpc_client
1 parent 546cc4b commit b598aed

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

IntegrationTests/src/bkr/inttest/labcontroller/test_proxy.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ def test_xmlrpc_recipe_log_after_finished(self):
929929
s.recipe_upload_file(self.recipe.id, '/', 'recipe-log', 10, None, 0,
930930
b64encode('a' * 10))
931931
self.fail('should raise')
932-
except xmlrpclib.Fault as fault:
932+
except xmlrpc_client.Fault as fault:
933933
self.assertTrue('Cannot register file for finished recipe'
934934
in fault.faultString)
935935

@@ -1007,7 +1007,7 @@ def test_xmlrpc_task_log_after_finished(self):
10071007
s.task_upload_file(task.id, '/', 'task-log', 10, None, 0,
10081008
b64encode('a' * 10))
10091009
self.fail('should raise')
1010-
except xmlrpclib.Fault as fault:
1010+
except xmlrpc_client.Fault as fault:
10111011
self.assertTrue('Cannot register file for finished task'
10121012
in fault.faultString)
10131013

@@ -1090,7 +1090,7 @@ def test_xmlrpc_result_log_after_finished(self):
10901090
s.result_upload_file(result.id, '/', 'result-log-after-finished',
10911091
10, None, 0, b64encode('a' * 10))
10921092
self.fail('should raise')
1093-
except xmlrpclib.Fault as fault:
1093+
except xmlrpc_client.Fault as fault:
10941094
self.assertTrue('Cannot register file for finished task'
10951095
in fault.faultString)
10961096

@@ -1164,7 +1164,7 @@ def test_large_xmlrpc_request_is_rejected(self):
11641164
s.task_upload_file(123, 'debug', '.task_beah_raw', 4096, '', 1024,
11651165
'a' * (1024 * 1024 * 10 + 1))
11661166
self.fail('should raise')
1167-
except xmlrpclib.ProtocolError as e:
1167+
except xmlrpc_client.ProtocolError as e:
11681168
self.assertEqual(e.errcode, 413)
11691169

11701170
# https://bugzilla.redhat.com/show_bug.cgi?id=1003454
@@ -1203,8 +1203,8 @@ def test_max_logs_per_recipe_limit_is_enforced(self):
12031203
session.expire(result)
12041204
self.assertEqual(len(result.logs), 3500)
12051205
# Test XMLRPC endpoint for result logs
1206-
s = xmlrpclib.ServerProxy(self.get_proxy_url(), allow_none=True)
1207-
with assertRaisesRegex(self, xmlrpclib.Fault, 'Too many logs'):
1206+
s = xmlrpc_client.ServerProxy(self.get_proxy_url(), allow_none=True)
1207+
with assertRaisesRegex(self, xmlrpc_client.Fault, 'Too many logs'):
12081208
s.result_upload_file(result.id, '/', 'result-log', 10, None, 0,
12091209
b64encode('a' * 10))
12101210
# Test POST endpoint for result logs
@@ -1214,8 +1214,8 @@ def test_max_logs_per_recipe_limit_is_enforced(self):
12141214
self.assertEqual(response.status_code, 403)
12151215
self.assertIn('Too many logs in recipe', response.text)
12161216
# Test XMLRPC endpoint for task logs
1217-
s = xmlrpclib.ServerProxy(self.get_proxy_url(), allow_none=True)
1218-
with assertRaisesRegex(self, xmlrpclib.Fault, 'Too many logs'):
1217+
s = xmlrpc_client.ServerProxy(self.get_proxy_url(), allow_none=True)
1218+
with assertRaisesRegex(self, xmlrpc_client.Fault, 'Too many logs'):
12191219
s.task_upload_file(task.id, '/', 'task-log', 10, None, 0,
12201220
b64encode('a' * 10))
12211221
# Test POST endpoint for task logs

0 commit comments

Comments
 (0)