Merge pull request #197 from mdsol/feature/prohib-create

Allow prohibition operations to be created w tilde prefix

Author: ejinotti-mdsol

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.0.7
+* Allow prohibition operations to be created without workaround.
+
 ## 4.0.6
 * Fallback to empty hash when extra_attributes are not set.
 

lib/policy_machine/policy_element.rb

@@ -198,9 +198,6 @@ def allowed_assignee_classes
   # An operation in a policy machine.
   class Operation < PolicyElement
     def self.create(unique_identifier, policy_machine_uuid, pm_storage_adapter, extra_attributes = {}, prohibition = false)
-      if unique_identifier =~ /^~/ && !prohibition
-        raise ArgumentError, "A non-prohibition operation cannot start with '~'"
-      end
       new_pe = new(unique_identifier, policy_machine_uuid, pm_storage_adapter, nil, extra_attributes)
       new_pe.stored_pe = pm_storage_adapter.add_operation(unique_identifier, policy_machine_uuid, extra_attributes)
       new_pe

lib/policy_machine/version.rb

@@ -1,3 +1,3 @@
 class PolicyMachine
-  VERSION = "4.0.6"
+  VERSION = "4.0.7"
 end

spec/support/shared_examples_policy_machine.rb

@@ -395,11 +395,6 @@
   end
 
   describe 'Operations' do
-    it 'does not allow an operation to start with a ~' do
-      expect{policy_machine.create_operation('~apple')}.to raise_error(ArgumentError)
-      expect{policy_machine.create_operation('apple~')}.not_to raise_error
-    end
-
     it 'can derive a prohibition from an operation and vice versa' do
       @op = policy_machine.create_operation('fly')
       expect(@op.prohibition).to be_prohibition