Skip to content

Add fillet intersection method #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 128 commits into
base: main
Choose a base branch
from
Draft

Add fillet intersection method #272

wants to merge 128 commits into from

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented May 23, 2025

Purpose

Merge the fillet intersection method into the rest of DVGeoMulti. This method allows for individual parameterization of two components (e.g. wing and fuselage) connected by a fillet. The fillet is not parameterized, it follows the other two components using inverse distance warping.

These changes involve some restructuring of existing DVGeoMulti code to take advantage of the shared methods between the original intersection method and this one. This PR will also add a test to the pyGeo tests.

I also made a change to pyGeo's FFD writing that lets you turn off writing the embedded volume so the output file has one less zone and it's easier to view a bunch in tecplot.

I'll add a tutorial to MACH-Aero to document this method once the journal paper is published.

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I'm adding my 2D test case as a test for this new code, these new tests should run successfully.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

gawng and others added 30 commits November 30, 2023 17:38
coordXfer callback function capability for the fillet method in DVGeoMulti + parallel DV bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants