Fixing bug in local DVs #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomangano
reviewed
May 3, 2022
| @@ -229,12 +229,6 @@ def __init__(self, name, lower, upper, scale, axis, coefListIn, mask, config, se | |||
| super().__init__(name=name, value=np.zeros(nVal, "D"), nVal=nVal, lower=None, upper=None, scale=scale) | |||
|
|
|||
| self.config = config | |||
| if lower is not None: | |||
There was a problem hiding this comment.
why are you removing these lines?
There was a problem hiding this comment.
That portion is duplicated in the class it inherits from, geoDV, so it shouldn't be necessary here.
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
===========================================
- Coverage 62.62% 51.70% -10.92%
===========================================
Files 45 45
Lines 11219 11213 -6
===========================================
- Hits 7026 5798 -1228
- Misses 4193 5415 +1222
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
joanibal
approved these changes
May 3, 2022
marcomangano
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The changes in #130 to the DV classes introduced an issue that caused my cases and the tutorial wing and airfoil to not run, they exited immediately with SNOPT saying the problem was infeasible. I believe the issue is typos in
geoDVLocalandgeoDVSpanwiseLocal, which this should fix.The bigger question is why the MACH and pyGeo tests still passed with this issue and how tests could catch it.
Expected time until merged
A day or two, there are only a few changed lines but someone who has cases that use different types of DVs might want to test with this to make sure everything is working.
Type of change
Testing
Without this change, running the tutorial scripts in Docker (I tried
u20-gcc-ompi-latest) will result in an immediate exit with no apparent errors and a10 14code from SNOPT.Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted