You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way the Colinearity and PlanarityConstraints compute derivatives causes incorrect / spurious nonzero derivative values to appear if inputs (e.g. points, axes) contain true zero values.
The problem is this line which appears in two places in DVConstraints /(2.0*numpy.sqrt(tmpX[i]))
Steps to reproduce issue
Turn derivative checking back on in test_DVConstraints tests 9 and 13b. It is currently turned off in the baseline case because the derivatives will contain different values depending on whether pyspline is compiled using Intel or GCC (produces near-zero floats in different places which causes the derivatives to be different)
Proposed fix
Instead of checking whether tmpX is exactly zero, check if it is nearly zero to within some tol
Or deprecate these constraints if nobody is using them.
The text was updated successfully, but these errors were encountered:
Description
The way the Colinearity and PlanarityConstraints compute derivatives causes incorrect / spurious nonzero derivative values to appear if inputs (e.g. points, axes) contain true zero values.
The problem is this line which appears in two places in DVConstraints
/(2.0*numpy.sqrt(tmpX[i]))
Steps to reproduce issue
Turn derivative checking back on in test_DVConstraints tests 9 and 13b. It is currently turned off in the baseline case because the derivatives will contain different values depending on whether pyspline is compiled using Intel or GCC (produces near-zero floats in different places which causes the derivatives to be different)
Proposed fix
Instead of checking whether tmpX is exactly zero, check if it is nearly zero to within some tol
Or deprecate these constraints if nobody is using them.
The text was updated successfully, but these errors were encountered: