Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define base classes to unify the various DVGeo modules #125

Closed
ewu63 opened this issue Mar 15, 2022 · 1 comment
Closed

Define base classes to unify the various DVGeo modules #125

ewu63 opened this issue Mar 15, 2022 · 1 comment
Assignees

Comments

@ewu63
Copy link
Collaborator

ewu63 commented Mar 15, 2022

Description

Currently, DVGeoVSP and DVGeoESP do not share any code with DVGeo, but mimics its API. This results in potential inconsistencies such as #124.

The solution is probably to define the API via an abstract base class, which is then inherited by all the various modules.

@hajdik hajdik self-assigned this Mar 15, 2022
@hajdik hajdik mentioned this issue Mar 25, 2022
12 tasks
@hajdik
Copy link
Contributor

hajdik commented May 3, 2022

Closed with #130

@hajdik hajdik closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants