Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPhys testing #322

Open
lamkina opened this issue Sep 26, 2023 · 2 comments
Open

MPhys testing #322

lamkina opened this issue Sep 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request mphys

Comments

@lamkina
Copy link
Contributor

lamkina commented Sep 26, 2023

Description

We need to add unit and regression testing for the MPhys layer.

Once we merge PRs #307, #308, and #321 we should create a new PR to add unit and regression tests for MPhys. For the most part, we can mirror the existing ADflow tests and make sure the OpenMDAO derivatives, data, and outputs match with MACH only cases.

@lamkina lamkina added enhancement New feature or request mphys labels Sep 26, 2023
@A-CGray
Copy link
Member

A-CGray commented Sep 27, 2023

I guess the main question on this matter is how do we test the parts of the MPhys wrapper that are only used when coupling ADflow to other disciplines? We can add tests that use aerostructural and aeropropulsive scenarios but then the ADflow tests are relying on other codes.

@lamkina
Copy link
Contributor Author

lamkina commented Sep 27, 2023

I think the MPhys tests that live in the ADflow repo should only test the parts of MPhys that interact with ADflow/MACH. The discipline coupling tests can exist in the MPhys repo when we get the dockerized testing workflow set up for all the codes that we couple to MPhys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mphys
Projects
None yet
Development

No branches or pull requests

3 participants