Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): automatically wrap markdown files #6032

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Apr 21, 2022

I really don't like manually wrapping markdown files.

Two parts: first commit makes the config change, second commit updates existing markdown files.

@fiji-flo
Copy link
Contributor

I like it how about the rest of the team?
@Guyzeroth @caugner @schalkneethling

@schalkneethling schalkneethling added enhancement Improves an existing feature. 🚉 platform keeping the platform healthy labels Apr 21, 2022
@fiji-flo
Copy link
Contributor

@LeoMcA can you fix the failing test?

@queengooborg
Copy link
Collaborator

In mdn/content#6936, there was strong writer preference towards not wrapping lines in the Markdown (and I'm also in favor of not wrapping lines; I unwrap them whenever I get the chance). This PR updates Yari's internal files (though unintentionally affects content), but shouldn't we follow the same principles between content and yari?

@LeoMcA
Copy link
Member Author

LeoMcA commented Apr 27, 2022

Oh dear, let me revert the .prettierrc changes to fix #6075, before figuring out how to apply those changes without affecting h2m.

shouldn't we follow the same principles between content and yari?

I wouldn't say so: the repos have different editors, and audiences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature. 🚉 platform keeping the platform healthy
Projects
Development

Successfully merging this pull request may close these issues.

4 participants