Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading mode is not working properly #7648

Open
charles-prof opened this issue Nov 23, 2022 · 6 comments
Open

Reading mode is not working properly #7648

charles-prof opened this issue Nov 23, 2022 · 6 comments
Labels
3rd-party:Reader View Firefox Reader View // Safari Reader View // Chrome Reader Mode help wanted If you know something about this topic, we would love your help! idle p4 Not urgent, only if time allows

Comments

@charles-prof
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/MDN/Community/Issues

What specific section or headline is this issue about?

reading mode does not work properly

What information was incorrect, unhelpful, or incomplete?

Web assembly introduction page is not showing up properly in reading mode.

https://developer.mozilla.org/en-US/docs/WebAssembly

image

What did you expect to see?

properly formatted text (webpage) for reading

Do you have any supporting links, references, or citations?

no

Do you have anything more you want to share?

This is a simple issue. reporting for first time is overwhelming.

Additional question forum link or community chat link would be helpful to easily ask what this (what I see or experience in this web app) means

because of the doubt whether it is a firefox bug to be reported in bugzilla or here.

even a mail support is good for asking

MDN metadata

Page report details
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 23, 2022
@wbamberg wbamberg transferred this issue from mdn/content Nov 23, 2022
@caugner caugner added help wanted If you know something about this topic, we would love your help! p4 Not urgent, only if time allows 3rd-party Issues related to third-parties, such as Pocket or Google Translate and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 24, 2022
@caugner
Copy link
Contributor

caugner commented Nov 24, 2022

Hi @charles-prof, thank you for taking the time to report this issue. 👋

This is similar to #5358, but much worse, because the most important content sections of the page (namely the introduction, among others) are omitted in the Firefox Reader View.

As mentioned in this comment:

The Firefox team pointed me to https://github.com/mozilla/readability/blob/master/Readability.js, which is the underlying implementation that decides what elements to show.

What may be happening here is that the high number of <dl>/<dt>/<dd> elements causes the Firefox Reader View to give that section's ancestors such a low content score (see here) that the comparatively few text in the sections above don't increase it enough (see here), and so other nodes are picked instead.

I'm not sure there is much that we can do, but it's definitely worth opening an issue in https://github.com/mozilla/readability/, referencing this issue. 🙏

@caugner caugner added 3rd-party:Reader View Firefox Reader View // Safari Reader View // Chrome Reader Mode and removed 3rd-party Issues related to third-parties, such as Pocket or Google Translate labels Nov 24, 2022
@caugner
Copy link
Contributor

caugner commented Nov 24, 2022

FWIW Safari Reader View does not have this issue:

image

@caugner
Copy link
Contributor

caugner commented Nov 24, 2022

Chrome Reader Mode (behind a flag) is not affected either:

image

@charles-prof
Copy link
Author

I'm not sure there is much that we can do, but it's definitely worth opening an issue in https://github.com/mozilla/readability/, referencing this issue. 🙏

Thanks for pointing me in the right direction.

As I was trying to inspect the console before reporting. The page rendered correctly in reader mode.

I checked the console. ( i turned off vue.js devtools to check if extension is making this but thst's not the case)

image

Layout is forced before page loading. - This is making the content unreadable but if i hit f5 to refresh the page, the content loads correctly.

This only affects the initial loading when we hit f9 or entering reading mode using icon in address bar.

@caugner
Copy link
Contributor

caugner commented Nov 29, 2022

This only affects the initial loading when we hit f9 or entering reading mode using icon in address bar.

Good catch, I have now filed this as bug 1803192 in the Firefox bug tracker.

@caugner
Copy link
Contributor

caugner commented May 15, 2024

FWIW The issue has been reported in the Firefox Readability repository in December 2022.

@github-actions github-actions bot removed the idle label May 15, 2024
@github-actions github-actions bot added the idle label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party:Reader View Firefox Reader View // Safari Reader View // Chrome Reader Mode help wanted If you know something about this topic, we would love your help! idle p4 Not urgent, only if time allows
Projects
Status: No status
Development

No branches or pull requests

2 participants