New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] markdown guideline #1773

Merged

hochan222 merged 6 commits into mdn:main from hochan222:markdown-guide

Aug 15, 2021

Member

hochan222 commented Jul 28, 2021 •

edited

Loading

issue: #1698 (comment)

markdown guideline 초안입니다.

해당 과정을 없애기 위해, 추후에 일괄적으로 변경하는 작업을 해야합니다. Convert Web/JavaScript to markdown content#6936
일괄적으로 변경하는 작업에는 markdown으로 변환하는데 문제가 생기는것들에 대해 html 파일 정제가 선행되어야합니다. (id,class제거 등)


          feat: add markdown guideline

27e1135

hochan222 requested review from a team, fiji-flo, yechoi42, cos18, pje1740, yujo11 and igy95 and removed request for a team and fiji-flo

July 28, 2021 14:27

hochan222 commented

View reviewed changes

docs/ko/markdown-guide.md Outdated Show resolved Hide resolved


          Update docs/ko/markdown-guide.md

ee5a3c9

hochan222 commented

View reviewed changes

docs/ko/markdown-guide.md Outdated Show resolved Hide resolved


          Update docs/ko/markdown-guide.md

43c3aae

hochan222 commented

View reviewed changes

docs/ko/markdown-guide.md Show resolved Hide resolved


          Update docs/ko/markdown-guide.md

c604062

hochan222 added the l10n-ko label

hochan222 commented

View reviewed changes

docs/ko/markdown-guide.md Outdated Show resolved Hide resolved


          Update docs/ko/markdown-guide.md

4f4cbee

github-actions bot removed the l10n-ko label

hochan222 commented

View reviewed changes

docs/ko/markdown-guide.md Show resolved Hide resolved


          Update docs/ko/markdown-guide.md

b577411

Member Author

hochan222 commented Jul 28, 2021

@mdn/yari-content-ko

MDN ko locale Markdown 번역에 대한 일반 지침 (리뷰어) 을 꼭 따라주세요.

hochan222 added the l10n-ko label

cos18 approved these changes

View reviewed changes

Collaborator

cos18 left a comment

확인했습니다!

yechoi42 reviewed

View reviewed changes

docs/ko/markdown-guide.md Show resolved Hide resolved

Member

igy95 commented Aug 2, 2021

확인했습니다 :) 👍🏻👍🏻 리뷰이, 리뷰어 PR 템플릿이 정착될수록 리뷰하기가 한결 편하네요.

igy95 approved these changes

View reviewed changes

pje1740 approved these changes

View reviewed changes

Collaborator

pje1740 left a comment

확인이 많이 늦었습니다...! 내용 수정, 확장자 수정으로 분리하는 것으로 이해했습니다! 감사합니다 :)

hochan222 merged commit 93f5d72 into mdn:main

hochan222 mentioned this pull request

refactor: add feedback(#1773) #2074

Merged

hochan222 added a commit that referenced this pull request


          refactor: add feedback(#1773) (#2074)

cf4a79f

* refactor: add feedback(#1773)

* docs: ㅅ파일변경 이유 설명 추가

* feat: guideline for  italics (#1537)

* Update docs/ko/translation-guide.md

hochan222 mentioned this pull request

[ko] Markdown Guildline 만들기 #1637

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yechoi42 yechoi42 left review comments

igy95 igy95 approved these changes

pje1740 pje1740 approved these changes

cos18 cos18 approved these changes

yujo11 Awaiting requested review from yujo11

Labels

l10n-ko