fix: history-api demo #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbamberg
reviewed
Nov 17, 2023
history-api/script.js
Outdated
| @@ -23,7 +23,7 @@ document.addEventListener("click", async (event) => { | |||
| displayContent(json); | |||
| // Add a new entry to the history. | |||
| // This simulates loading a new page. | |||
| history.pushState(json, "", creature); | |||
| history.pushState(json, "", `${creature}.html`); | |||
There was a problem hiding this comment.
When you say "advertised as" do you mean in the href? Do you think it is better to update the state, as here, or to update the href? (it feels better to me to update the href but not sure why).
There was a problem hiding this comment.
When you say "advertised as" do you mean in the href?
Yes, when we hover over a link it shows the anchor's path in bottom left corner of the browser.
it feels better to me to update the href but not sure why
In single page applications static looking links feel odd. Let's get rid of .html from paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues to fix:
*.htmlbut they reach non .html destinations./cc @wbamberg