Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference local favicon images #6052

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jun 16, 2021

What was wrong/why is this fix needed? (quick summary only)

Some pages relied on favicon images that would be part of the MDN platform. Clearly that didn't work out because MDN changed favicon images.
This PR solves that by download the images locally so the images are owned by the content and not optimistically dependent on something external.

MDN URL of the main page changed

See preview URLs

Issue number (if there is an associated issue)

Anything else that could help us review it

Based on #6001 (comment)

@peterbe peterbe requested a review from a team as a code owner June 16, 2021 13:55
@peterbe peterbe requested review from rachelandrew and removed request for a team June 16, 2021 13:55
@peterbe
Copy link
Contributor Author

peterbe commented Jun 16, 2021

Note, this PR also fixes 2 images (clock-demo-200px.png and clock-demo-400px.png) that incorrectly was referred to as the file attachments on mdn.mozillademos.org. So I fixed that too.

@peterbe peterbe requested review from sideshowbarker and removed request for rachelandrew June 16, 2021 13:57
@peterbe
Copy link
Contributor Author

peterbe commented Jun 16, 2021

@rachelandrew Sorry for the notification noise. I'm manually changing reviewer to @sideshowbarker because he worked on #6001.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Attributes/rel
Title: HTML attribute: rel
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.attributes.rel

URL: /en-US/docs/Web/HTML/Element/figure
Title: <figure>: The Figure with Optional Caption element
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/HTML/Using_HTML_sections_and_outlines#sectioning_roots
    • Can't resolve /en-US/docs/Web/Guide/HTML/Using_HTML_sections_and_outlines#sectioning_roots

External URLs

URL: /en-US/docs/Web/HTML/Attributes/rel
Title: HTML attribute: rel
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/img
Title: <img>: The Image Embed element
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/menuitem
Title: <menuitem>
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/figure
Title: <figure>: The Figure with Optional Caption element
on GitHub

No new external URLs

@sideshowbarker sideshowbarker changed the title reference local favicon images Reference local favicon images Jun 17, 2021
@sideshowbarker sideshowbarker merged commit 4829481 into mdn:main Jun 17, 2021
@peterbe peterbe deleted the reference-local-favicon-images branch June 17, 2021 14:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants