-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken image links on the img page #6001
Conversation
Thanks for raising this. While the replacement URLs work fine time, the existing URLs also seem to work fine for me:
And for me, those images are showing up as expected in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img |
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs |
That's interesting! They are broken for me :). |
Broken for me too. |
Very odd. They show up for me in Firefox — and in Firefox devtools I see this:
…but trying for the command line:
So my only guess it that I might be hitting the Cloudfront cache while y’all aren’t. Otherwise I have no clue. Maybe @mdn/core-dev has some idea. |
@sideshowbarker You could be right. However if the link proposed here works for everyone shouldn't we just merge this? [i.e. is this the intended file to display]? |
I have no objection to merging this — but we have other articles that use the same image URLs that this PR is changing:
…and we also have articles with other
So that’s why it’d seem like all of those must have used to work at some time before, and so if they’re not now, it could be good to know why — and to know if in general, we shouldn’t use And that’s why it seems to me it’d be good to hear from @mdn/core-dev before we start changing any of them. |
What I think we should do is download them all and stop referring to images with an absolute URL. <a href="https://developer.mozilla.org">
- <img src="https://developer.mozilla.org/static/img/favicon144.png"
+ <img src="favicon144.png"
alt="Visit the MDN site">
</a> we then download that favicon image and put it right next to the
Drawbacks of local images:
|
I have a Python script that isn't perfect but I'm slowly going through pages with it. |
I think #5906 was the only remaining open PR there — so I went ahead and reviewed it and merged it just now |
I propose we close this and review #6052 |
No merged, and commit message marked that as fixing this, so this is now closed too
👍 |
Images used as examples in the
img
page were pointing to broken URLshttps://developer.mozilla.org/en-US/docs/Web/HTML/Element/img