-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Django tutorial - needs a signup page #35484 #42327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. It is worth saying that Django does not support a signup page out of the box - since that is something that users might expect to be able to do.
However the lack of a registration page in this app is deliberate. Usually when you join a library you don't self-register. Instead you are registered by a librarian who performs various checks that you are who you say you are. In the design of this library that is done through the administration interface, which is available to librarians.
So what is required here is a note explaining those two things. Would you mind ammeding appropriately - remove the code changes and add a note?
Note that for code changes to the tutorial we require a parallel PR to https://github.com/mdn/django-locallibrary-tutorial - as that makes it easy to verify and test changes.
|
Hi, I have removed the signup code and added the note explaining the registration design choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Abhi-Sharma Can you please remove the two images that are no longer required? EDIT. Now done.
hamishwillee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @Abhi-Sharma . I've moved the comment and cut it back a bit. Much appreciated you chasing this up.
|
Preview URLs Flaws (1)URL:
|
This pull request adds missing documentation for user registration (signup) in the Django authentication tutorial. The current MDN page explains login, logout, and permissions, but it does not mention that Django does not include a built-in signup view, which leads to confusion for learners.
This PR introduces a clear, modern example of how to implement a registration route, form, view, and template using Django’s standard tools.