Skip to content

Conversation

@Abhi-Sharma
Copy link
Contributor

This pull request adds missing documentation for user registration (signup) in the Django authentication tutorial. The current MDN page explains login, logout, and permissions, but it does not mention that Django does not include a built-in signup view, which leads to confusion for learners.
This PR introduces a clear, modern example of how to implement a registration route, form, view, and template using Django’s standard tools.

@Abhi-Sharma Abhi-Sharma requested review from a team and mdn-bot as code owners December 9, 2025 17:53
@Abhi-Sharma Abhi-Sharma requested review from LeoMcA and estelle and removed request for a team December 9, 2025 17:53
@github-actions github-actions bot added Content:Learn Learning area docs size/xl [PR only] >1000 LoC changed labels Dec 9, 2025
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is worth saying that Django does not support a signup page out of the box - since that is something that users might expect to be able to do.

However the lack of a registration page in this app is deliberate. Usually when you join a library you don't self-register. Instead you are registered by a librarian who performs various checks that you are who you say you are. In the design of this library that is done through the administration interface, which is available to librarians.

So what is required here is a note explaining those two things. Would you mind ammeding appropriately - remove the code changes and add a note?


Note that for code changes to the tutorial we require a parallel PR to https://github.com/mdn/django-locallibrary-tutorial - as that makes it easy to verify and test changes.

@Abhi-Sharma
Copy link
Contributor Author

Hi, I have removed the signup code and added the note explaining the registration design choice.
Please review the updated changes. Thank you!

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xl [PR only] >1000 LoC changed labels Dec 12, 2025
@caugner caugner removed request for LeoMcA and mdn-bot December 12, 2025 15:06
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abhi-Sharma Can you please remove the two images that are no longer required? EDIT. Now done.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @Abhi-Sharma . I've moved the comment and cut it back a bit. Much appreciated you chasing this up.

@github-actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Learn_web_development/Extensions/Server-side/Django/Authentication
Title: Django Tutorial Part 8: User authentication and permissions
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve

@hamishwillee hamishwillee merged commit 668056c into mdn:main Dec 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants