Skip to content

New CSS Module: CSS color adjustment #25211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 13, 2023
Merged

New CSS Module: CSS color adjustment #25211

merged 8 commits into from
Mar 13, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 10, 2023

This module was not previously documented.

@estelle estelle requested a review from a team as a code owner March 10, 2023 00:25
@estelle estelle requested review from dipikabh and removed request for a team March 10, 2023 00:25
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/CSS_color_adjustment
Title: CSS color adjustment
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/color-adjust redirects to /en-US/docs/Web/CSS/print-color-adjust

(comment last updated: 2023-03-11 06:32:21)

@estelle estelle mentioned this pull request Mar 10, 2023
Open
teoli2003
teoli2003 suggested changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some adjustments, fixing the flaws that Yari is reporting. One question is still open, though.

dipikabh
dipikabh requested changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment :)

estelle and others added 5 commits March 10, 2023 11:39
@estelle @teoli2003
Update files/en-us/web/css/css_color_adjustment/index.md
d2c0f51 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle @teoli2003
Update files/en-us/web/css/css_color_adjustment/index.md
d6385a1 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle @teoli2003
Update files/en-us/web/css/css_color_adjustment/index.md
4ac1528 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle @teoli2003
Update files/en-us/web/css/css_color_adjustment/index.md
fc9dc1e 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle @dipikabh
Update files/en-us/web/css/css_color_adjustment/index.md
0a6f35f 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested review from teoli2003 and dipikabh March 10, 2023 19:41
@teoli2003
Copy link
Contributor

Just one comment :)

We need to fix slugs, titles, and links to them for all modules. It is impredictable right now, which makes authoring painful.

dipikabh
dipikabh approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dipikabh dipikabh merged commit 6282dda into mdn:main Mar 13, 2023
@estelle estelle deleted the coloradjust branch July 14, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

+1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @teoli2003 @dipikabh