Skip to content

hue-rotate() filter function. Add SVG back in.#24968

Merged
teoli2003 merged 7 commits intomdn:mainfrom
estelle:huerotate
Mar 3, 2023
Merged

hue-rotate() filter function. Add SVG back in.#24968
teoli2003 merged 7 commits intomdn:mainfrom
estelle:huerotate

Conversation

@estelle
Copy link
Member

@estelle estelle commented Feb 28, 2023

The SVG equivalents were removed from the filter property page. We don't want to lose the information while we wait for the SVG section to get some love, so including the SVG as a tertiary example here until we have a better home for it.

@estelle estelle requested a review from a team as a code owner February 28, 2023 20:45
@estelle estelle requested review from dipikabh and removed request for a team February 28, 2023 20:45
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/filter-function/hue-rotate
Title: hue-rotate()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-us/docs/Web/CSS/filter_effects/

(comment last updated: 2023-03-01 23:40:18)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One flaw fixing and this is good to go.


{{EmbedLiveSample('With_the_filter_property','100%','220')}}

### With url() and the SVG hue-rotate filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the context here. At the OWD meeting yesterday (Ruth and Bryan are in) we reached the following consensus:

  • Fundamentally this should be elsewhere under SVG
  • It is too much work (and a rabbit hole) to get the SVG pages in a good enough shape so that can be moved there
  • We don't want to lose this data

So we decided to allow this here for now. When the SVG filter area will be in a better shape this can be moved.

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle estelle requested a review from teoli2003 March 3, 2023 00:56
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants