Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties should not be validated #5

Open
jcampoy opened this issue Jun 4, 2018 · 1 comment
Open

Properties should not be validated #5

jcampoy opened this issue Jun 4, 2018 · 1 comment

Comments

@jcampoy
Copy link

jcampoy commented Jun 4, 2018

Currently there is a validation and only existent properties in portal.properties can be encoded.
The problem is that some of them are part of a comment or can be added as new composing them with a suffix + object's class name:

Example 1:
#web.server.protocol=https

Example 2:
#
# Entity level caching for a specific type of value object can be configured
# by using a property name that includes the value object's class name.
#
value.object.entity.cache.enabled.com.liferay.portal.kernel.model.Layout=true
value.object.entity.cache.enabled.com.liferay.portal.kernel.model.User=true

@riccardo-ferrari
Copy link

Having the same issue but I really like this kind of validation!

I like some sanity check. Safes me from mistyping and from using "legacy" properties too.

It is true that currently only checks against master branch however I see this as a nice to have improvement to validate against the different portal versions.

Thanks for the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants