Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The button element submits the form when clicked #46

Closed
savissimo opened this issue May 20, 2022 · 2 comments
Closed

The button element submits the form when clicked #46

savissimo opened this issue May 20, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@savissimo
Copy link
Contributor

Thank you for this component! It's so easy to setup and get working, it's really great!

But there's a problem: I made Coloris pickers out of my <input type="text" /> elements inside a form. When I closed the picker, the form got submitted. After inspecting, I've noticed that a button element is created, but since it has no type attribute it is assumed to be type="submit".

Can you set a default type="button" attribute, please?

@mdbassit mdbassit added the bug Something isn't working label May 20, 2022
@mdbassit mdbassit self-assigned this May 20, 2022
@mdbassit
Copy link
Owner

Thank you for the bug report, indeed I haven't tested the color picker inside a form. I will release a fix in a bit.

@mdbassit
Copy link
Owner

Merged. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants