Skip to content

Commit

Permalink
Enhance the unit conversion in the EMF Exporter (open-telemetry#35937)
Browse files Browse the repository at this point in the history
  • Loading branch information
bjrara authored Nov 23, 2024
1 parent b509550 commit 4144b21
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 2 deletions.
27 changes: 27 additions & 0 deletions .chloggen/awsemfexporter-enhancements.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: awsemfexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Improvement unit conversion during EMF log translation"

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [35937]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
7 changes: 6 additions & 1 deletion exporter/awsemfexporter/grouped_metric.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ func translateUnit(metric pmetric.Metric, descriptor map[string]MetricDescriptor
}
}
switch unit {
case "1":
unit = ""
case "ns":
// CloudWatch doesn't support Nanoseconds
unit = ""
case "ms":
unit = "Milliseconds"
case "s":
Expand All @@ -200,7 +205,7 @@ func translateUnit(metric pmetric.Metric, descriptor map[string]MetricDescriptor
unit = "Microseconds"
case "By":
unit = "Bytes"
case "Bi":
case "bit":
unit = "Bits"
}
return unit
Expand Down
4 changes: 3 additions & 1 deletion exporter/awsemfexporter/grouped_metric_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,12 @@ func TestTranslateUnit(t *testing.T) {
translateUnitCases := map[string]string{
"Count": "Count",
"ms": "Milliseconds",
"ns": "",
"1": "",
"s": "Seconds",
"us": "Microseconds",
"By": "Bytes",
"Bi": "Bits",
"bit": "Bits",
}
for input, output := range translateUnitCases {
t.Run(input, func(_ *testing.T) {
Expand Down

0 comments on commit 4144b21

Please sign in to comment.