Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Automatically set --enable-source-maps when sourceMap is active in tsConfig.json #32

Closed
Palaxx opened this issue May 17, 2024 · 2 comments · Fixed by #33
Closed

Comments

@Palaxx
Copy link
Contributor

Palaxx commented May 17, 2024

Hello,

Running borp without additional configurations does not generate the source maps files, even if sourceMap is active in tsconfig.json file.

I know we can achive the goal setting the NODE_OPTIONS enviroment variable before running the tests, somenthing like this

NODE_OPTIONS=--enable-source-maps borp ...

but probably we can automatically set it from borp only if sourceMap=true exists in tsconfig.json.
What do you think about it?
If you think it is ok, i can open a new PR in the next days

@mcollina
Copy link
Owner

Definitely! Would you like to send a PR?

@Palaxx
Copy link
Contributor Author

Palaxx commented May 18, 2024

Sure I'll do in the next days.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants