Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git version parsing using regex in bootstrap.py #445

Open
fraguada opened this issue Feb 3, 2022 · 1 comment
Open

Fix git version parsing using regex in bootstrap.py #445

fraguada opened this issue Feb 3, 2022 · 1 comment
Assignees
@dan-rigdon-bel
Labels
build issues related to build tools, ci, etc.

Comments

@fraguada
Copy link
Member

fraguada commented Feb 3, 2022

@dan-rigdon-bel there was a bug in the workflow_ci script that didn't use the check for changes in build scripts to in any of the build steps, which means the changes you made with to bootstrap.py here seemed to pass checks just fine but didn't actually trigger any builds.
@fraguada fraguada assigned fraguada and dan-rigdon-bel and unassigned fraguada Feb 3, 2022
@fraguada
Copy link
Member Author

fraguada commented Feb 7, 2022

fyi @dan-rigdon-bel I've reverted your changes, but left your changes commented in the bootstrap script:
https://github.com/mcneel/rhino3dm/blob/main/script/bootstrap.py#L298-L309

@fraguada fraguada added the build issues related to build tools, ci, etc. label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-rigdon-bel dan-rigdon-bel

Labels
build issues related to build tools, ci, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fraguada @dan-rigdon-bel