Fix for node 6.x. Be explicit about crypto update input encoding latin1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschenkelman
force-pushed
the
node6fix
branch
from
e11daba
to
97d4bd1
Compare
ziluvatar
reviewed
Mar 27, 2017
| @@ -59,7 +59,7 @@ SAML.prototype.validateSignature = function (xml, options, callback) { | |||
| var base64cer = embeddedSignature[0].firstChild.toString(); | |||
| var shasum = crypto.createHash('sha1'); | |||
| var der = new Buffer(base64cer, 'base64').toString('binary'); | |||
| shasum.update(der); | |||
| shasum.update(der, 'latin1'); | |||
There was a problem hiding this comment.
We have thumbprint running this as well, it could be extracted.
Anyway, why don't simply passing the buffer to shasum.update() and we avoid 2 convertions, the first one to binary/latin1 and the other one (internally in crypto from latin1 to buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained here, this is a breaking change.
Every time this appears
if (!decoder.Decode(env, args[0].As<String>(), args[1], UTF8)),args[1]is the encoding parameter, andUTF8is the default.We need to be explicit about the encoding when calling update. This means using
'latin1'which is the string that represents the previousBINARYconstant.