feat(ts/createDetourMachine): default fetchNearestIntersection result to an Em Dash on error
#2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/asn/em-dash-intersection
branch
from
16477f2 to
7496d2c
Compare
…` to default to an Em Dash
…lt to an Em Dash on error
firestack
force-pushed
the
kf/asn/em-dash-intersection
branch
from
7496d2c to
5cbc5e7
Compare
firestack
commented
Mar 11, 2025
| @@ -83,7 +83,7 @@ describe("DiversionPage autosave flow", () => { | |||
| }) | |||
|
|
|||
| await waitFor(() => { | |||
| expect(putDetourUpdate).toHaveBeenCalledTimes(3) | |||
| expect(putDetourUpdate).toHaveBeenCalledTimes(5) | |||
There was a problem hiding this comment.
not quite sure why this changed, I tried to figure out if there was a way to do "at least 2 times" but didn't see anything.
There was a problem hiding this comment.
okay actually I think this changed due to doing "set.nearest-intersection-fallback" in Pick Start Point
firestack
commented
Mar 11, 2025
| @@ -40,7 +40,7 @@ beforeEach(() => { | |||
| jest.mocked(getTestGroups).mockReturnValue([]) | |||
| jest | |||
| .mocked(fetchNearestIntersection) | |||
| .mockResolvedValue("Returned Intersection") | |||
| .mockReturnValue(neverPromise()) | |||
There was a problem hiding this comment.
The intersection isn't used in these tests and it's just easier to have the promise never return, because otherwise you run into "An update inside a test was not wrapped in act(...)."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1203014709808707/1209629085185045