Skip to content

Commit 1b49d49

Browse files
committed
ordered_float:NotNan may contain NaN after unwinding in assignment operators
After using an assignment operators such as `NotNan::add_assign`, `NotNan::mul_assign`, etc., it was possible for the resulting `NotNan` value to contain a `NaN`. This could cause undefined behavior in safe code, because the safe `NotNan::cmp` method contains internal unsafe code that assumes the value is never `NaN`. (It could also cause undefined behavior in third-party unsafe code that makes the same assumption, as well as logic errors in safe code.) This was mitigated starting in version 0.4.0, by panicking if the assigned value is NaN. However, in affected versions from 0.4.0 onward, code that continued after using unwinding to catch this panic could still observe the invalid value and trigger undefined behavior. The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring that the assignment operators panic without modifying the operand, if the result would be `NaN`. Fix details: reem/rust-ordered-float#20 reem/rust-ordered-float#71
1 parent 3ea0b30 commit 1b49d49

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
```toml
2+
[advisory]
3+
id = "RUSTSEC-0000-0000"
4+
package = "ordered-float"
5+
date = "2020-12-06"
6+
url = "https://github.com/reem/rust-ordered-float/pull/71"
7+
categories = []
8+
keywords = ["unwind"]
9+
10+
[versions]
11+
patched = ["^1.1.1", ">= 2.0.1"]
12+
unaffected = ["< 0.2.2"]
13+
14+
[affected]
15+
```
16+
17+
# ordered_float:NotNan may contain NaN after unwinding in assignment operators
18+
19+
After using an assignment operators such as `NotNan::add_assign`, `NotNan::mul_assign`, etc., it was possible for the resulting `NotNan` value to contain a `NaN`. This could cause undefined behavior in safe code, because the safe `NotNan::cmp` method contains internal unsafe code that assumes the value is never `NaN`. (It could also cause undefined behavior in third-party unsafe code that makes the same assumption, as well as logic errors in safe code.)
20+
21+
This was mitigated starting in version 0.4.0, by panicking if the assigned value is NaN. However, in affected versions from 0.4.0 onward, code that continued after using unwinding to catch this panic could still observe the invalid value and trigger undefined behavior.
22+
23+
The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring that the assignment operators panic without modifying the operand, if the result would be `NaN`.

0 commit comments

Comments
 (0)