Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The KeyBindingsList dialog tries to connect to non-existent signals #178

Closed
mbrlabs opened this issue Jul 9, 2022 · 0 comments · Fixed by #180
Closed

The KeyBindingsList dialog tries to connect to non-existent signals #178

mbrlabs opened this issue Jul 9, 2022 · 0 comments · Fixed by #180
Labels
bug Something isn't working

Comments

@mbrlabs
Copy link
Owner

mbrlabs commented Jul 9, 2022

Lorien version:
main branch, b017256

OS/device including version:
Windows 11

Issue description:
Many errors (66) of this kind:

E 0:00:01.142   Object::connect: In Object of type 'Label': Attempt to connect nonexistent signal 'bind_new_key' to method 'Control._bind_new_key'.
  <C++ Error>   Condition "!signal_is_valid" is true. Returned: ERR_INVALID_PARAMETER
  <C++ Source>  core\object.cpp:1462 @ Object::connect()
  <Stack Trace> KeyBindingsList.gd:47 @ _new_keybinding_entry()
                KeyBindingsList.gd:29 @ _populate_input_list()
                KeyBindingsList.gd:12 @ _ready()

Which happens in here:

child.connect("modified_binding", self, "_modify_keybinding", [action_name])
child.connect("bind_new_key", self, "_bind_new_key", [action_name])

It doesn't seem to have any negative effects though in a debug build. We should check if the child is the right type/node before trying to connect the signal. @MrApplejuice

Steps to reproduce:
Just launch Lorien in the editor and observe the Debugger error tab

@mbrlabs mbrlabs added the bug Something isn't working label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant