DS_2_3 (Doxy standards) and DS_2_4 (gitignore update)#6
Merged
Conversation
mbozada
requested changes
Mar 18, 2021
Owner
mbozada
left a comment
There was a problem hiding this comment.
So I think you can further adjust the .gitignore. I agree with everything you've ignored so far, but it seems like CmakeDoxyfile.in and CmakeDoxygenDefaults.cmake are generated in the initial cmake . + make steps of building Craft.
I feel safe ignoring them as well and just having this commit be the update to .gitignore and CraftDoc.
Collaborator
Author
Done and done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FINALLY, I got the .gitignore to work - turns out I had to undo some weird settings I managed to mess up in VS Code on my machine. (5 points between DS2.3 and DS2.4)
Doxygen produces html and tracks classes and such - please check to see if it's satisfactory.