Skip to content

DS_2_3 (Doxy standards) and DS_2_4 (gitignore update)#6

Merged
mbozada merged 4 commits intomasterfrom
DoxyBranch
Mar 18, 2021
Merged

DS_2_3 (Doxy standards) and DS_2_4 (gitignore update)#6
mbozada merged 4 commits intomasterfrom
DoxyBranch

Conversation

@alexreigle
Copy link
Collaborator

FINALLY, I got the .gitignore to work - turns out I had to undo some weird settings I managed to mess up in VS Code on my machine. (5 points between DS2.3 and DS2.4)

Doxygen produces html and tracks classes and such - please check to see if it's satisfactory.

@alexreigle alexreigle added the documentation Improvements or additions to documentation label Mar 18, 2021
@alexreigle alexreigle requested a review from mbozada March 18, 2021 01:26
Copy link
Owner

@mbozada mbozada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think you can further adjust the .gitignore. I agree with everything you've ignored so far, but it seems like CmakeDoxyfile.in and CmakeDoxygenDefaults.cmake are generated in the initial cmake . + make steps of building Craft.

I feel safe ignoring them as well and just having this commit be the update to .gitignore and CraftDoc.

@alexreigle alexreigle requested a review from mbozada March 18, 2021 23:08
@alexreigle
Copy link
Collaborator Author

So I think you can further adjust the .gitignore. I agree with everything you've ignored so far, but it seems like CmakeDoxyfile.in and CmakeDoxygenDefaults.cmake are generated in the initial cmake . + make steps of building Craft.

I feel safe ignoring them as well and just having this commit be the update to .gitignore and CraftDoc.

Done and done!

Copy link
Owner

@mbozada mbozada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mbozada mbozada merged commit af87443 into master Mar 18, 2021
@mbozada mbozada deleted the DoxyBranch branch March 18, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants