Skip to content

Commit

Permalink
Typo correction on issue 29 (not a problem, but cleaner code) in mode…
Browse files Browse the repository at this point in the history
…l.js

@@ -134,7 +134,7 @@ define(['api','backbone','utils'],
           op:             "getFeeds",
           cat_id:         catId,
           include_nested: false,
-          unread_only: settings.attributes.hideEmptyCategories=="true"     // get only feeds with unread articles
+          unread_only: settings.attributes.hideEmptyCategories     // get only feeds with unread articles
         };

Bug correction in model.js :
displaying the content of a feed did not work on HP Touchpad WebOS default browser.
Now it works but article displaying do not work yet.

@@ -301,7 +301,7 @@ define(['api','backbone','utils'],
             if (collection.feedId != feedId){
               /* this is another feed, force a clean
                 to trigger delete/add events */
-              collection.set({});
+                collection.set([]); // works on HP touchpad but collection.set({}) stopped the execution of code right here
             }

             // efficiently set the collection
  • Loading branch information
alexandrenorman committed May 13, 2013
1 parent fd5a512 commit 3df73b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/scripts/models.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ define(['api','backbone','utils'],
op: "getFeeds",
cat_id: catId,
include_nested: false,
unread_only: settings.attributes.hideEmptyCategories=="true" // get only feeds with unread articles
unread_only: settings.attributes.hideEmptyCategories // get only feeds with unread articles
};

api.ttRssApiCall(
Expand Down Expand Up @@ -301,7 +301,7 @@ define(['api','backbone','utils'],
if (collection.feedId != feedId){
/* this is another feed, force a clean
to trigger delete/add events */
collection.set({});
collection.set([]); // works on HP touchpad but collection.set({}) stopped the execution of code right here
}

// efficiently set the collection
Expand Down

0 comments on commit 3df73b1

Please sign in to comment.