Skip to content

Commit 23f582f

Browse files
committed
Merge branch 'master' of https://github.com/scop/MySQLTuner-perl into scop-master
2 parents e8495ce + 778cc60 commit 23f582f

File tree

1 file changed

+21
-1
lines changed

1 file changed

+21
-1
lines changed

mysqltuner.pl

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,26 @@ sub get_all_vars {
354354
$line =~ /([a-zA-Z_]*)\s*(.*)/;
355355
$mystat{$1} = $2;
356356
}
357+
# Workaround for MySQL bug #59393 wrt. ignore-builtin-innodb
358+
if (($myvar{'ignore_builtin_innodb'} || "") eq "ON") {
359+
$myvar{'have_innodb'} = "NO";
360+
}
361+
# have_* for engines is deprecated and will be removed in MySQL 5.6;
362+
# check SHOW ENGINES and set corresponding old style variables.
363+
# Also works around MySQL bug #59393 wrt. skip-innodb
364+
my @mysqlenginelist = `mysql $mysqllogin -Bse "SHOW ENGINES;" 2>/dev/null`;
365+
foreach my $line (@mysqlenginelist) {
366+
if ($line =~ /^([a-zA-Z_]+)\s+(\S+)/) {
367+
my $engine = lc($1);
368+
if ($engine eq "federated" || $engine eq "blackhole") {
369+
$engine .= "_engine";
370+
} elsif ($engine eq "berkeleydb") {
371+
$engine = "bdb";
372+
}
373+
my $val = ($2 eq "DEFAULT") ? "YES" : $2;
374+
$myvar{"have_$engine"} = $val;
375+
}
376+
}
357377
}
358378

359379
sub security_recommendations {
@@ -455,7 +475,7 @@ sub check_storage_engines {
455475
my $engines;
456476
$engines .= (defined $myvar{'have_archive'} && $myvar{'have_archive'} eq "YES")? greenwrap "+Archive " : redwrap "-Archive " ;
457477
$engines .= (defined $myvar{'have_bdb'} && $myvar{'have_bdb'} eq "YES")? greenwrap "+BDB " : redwrap "-BDB " ;
458-
$engines .= (defined $myvar{'have_federated'} && $myvar{'have_federated'} eq "YES")? greenwrap "+Federated " : redwrap "-Federated " ;
478+
$engines .= (defined $myvar{'have_federated_engine'} && $myvar{'have_federated_engine'} eq "YES")? greenwrap "+Federated " : redwrap "-Federated " ;
459479
$engines .= (defined $myvar{'have_innodb'} && $myvar{'have_innodb'} eq "YES")? greenwrap "+InnoDB " : redwrap "-InnoDB " ;
460480
$engines .= (defined $myvar{'have_isam'} && $myvar{'have_isam'} eq "YES")? greenwrap "+ISAM " : redwrap "-ISAM " ;
461481
$engines .= (defined $myvar{'have_ndbcluster'} && $myvar{'have_ndbcluster'} eq "YES")? greenwrap "+NDBCluster " : redwrap "-NDBCluster " ;

0 commit comments

Comments
 (0)