Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] About S3-FIFO evict #77

Closed
woodliu opened this issue Apr 7, 2024 · 2 comments
Closed

[BUG] About S3-FIFO evict #77

woodliu opened this issue Apr 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@woodliu
Copy link

woodliu commented Apr 7, 2024

When the cache full , it should evict some nodes.
From the S3-FIFO paper, when evict node from small or main queue, it should try to evict the node from the tail, like:
image
But here , it choose the evicted node from head, is this more reasonable ?

@woodliu woodliu added the bug Something isn't working label Apr 7, 2024
@woodliu
Copy link
Author

woodliu commented Apr 7, 2024

Sorry, my fault , it inset to the tail, and evict from head...

@woodliu woodliu closed this as completed Apr 7, 2024
@maypok86
Copy link
Owner

maypok86 commented Apr 7, 2024

Yes, it is only important to maintain FIFO order there. I put it in the tail and remove it from the head, because it is more familiar and intuitive for me. Also, this option is usually used more often because it has analogies from real life. For example, a queue at a store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants