Add two SlevomatCodingStandard.Functions sniffs

mayflower · Apr 22, 2021 · a779121 · a779121
1 parent 36e90fb
commit a779121
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/MO4/Sniffs/Commenting/PropertyCommentSniff.php b/MO4/Sniffs/Commenting/PropertyCommentSniff.php
@@ -69,6 +69,7 @@ public function __construct()
      * listening to.
      *
      * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint
+     * @phpcsSuppress SlevomatCodingStandard.Functions.UnusedParameter
      *
      * @param File $phpcsFile The file where this token was found.
      * @param int  $stackPtr  The position in the stack where this
@@ -241,6 +242,7 @@ protected function processTokenWithinScope(File $phpcsFile, $stackPtr, $currScop
      * Process tokens outside scope.
      *
      * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint
+     * @phpcsSuppress SlevomatCodingStandard.Functions.UnusedParameter
      *
      * @param File $phpcsFile The file where this token was found.
      * @param int  $stackPtr  The position in the stack where this

diff --git a/MO4/Tests/Formatting/UnnecessaryNamespaceUsageUnitTest.php b/MO4/Tests/Formatting/UnnecessaryNamespaceUsageUnitTest.php
@@ -41,11 +41,9 @@ class UnnecessaryNamespaceUsageUnitTest extends AbstractSniffUnitTest
      * The key of the array should represent the line number and the value
      * should represent the number of errors that should occur on that line.
      *
-     * @param string $testFile test file
-     *
      * @return array<int, int>
      */
-    protected function getErrorList(string $testFile = ''): array
+    protected function getErrorList(): array
     {
         return [];
     }

diff --git a/MO4/ruleset.xml b/MO4/ruleset.xml
@@ -136,10 +136,14 @@
             <property name="ignoreMultiline" value="true"/>
         </properties>
     </rule>
-    <!-- Require global functions to be referenced via a fully qualified name -->
-    <rule ref="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions"/>
     <!-- Require static closures for microoptimization -->
     <rule ref="SlevomatCodingStandard.Functions.StaticClosure"/>
+    <!-- Forbid unused function parameters -->
+    <rule ref="SlevomatCodingStandard.Functions.UnusedParameter"/>
+    <!-- Forbids useless parameter default values -->
+    <rule ref="SlevomatCodingStandard.Functions.UselessParameterDefaultValue"/>
+    <!-- Require global functions to be referenced via a fully qualified name -->
+    <rule ref="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions"/>
     <!-- Forbid multiple use statements on same line -->
     <rule ref="SlevomatCodingStandard.Namespaces.MultipleUsesPerLine"/>
     <!-- Require one newline around namespace declaration -->