Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version to get newer docker image #208

Closed
falk-w opened this issue Sep 18, 2024 · 6 comments
Closed

Release new version to get newer docker image #208

falk-w opened this issue Sep 18, 2024 · 6 comments

Comments

@falk-w
Copy link

falk-w commented Sep 18, 2024

I see a new main image got built after v1.5.0 has been built quite a while ago (10 months).

Would it be possible to bump the version also to get a newer docker image? (Your Go Bump had some security fixes e.g. golang/go#67680 and I'd like to see them in an image that can be referenced in the official helm chart - https://github.com/prometheus-community/helm-charts/tree/main/charts/alertmanager-snmp-notifier )

@maxwo
Copy link
Owner

maxwo commented Sep 29, 2024

Good point indeed. I just released the v1.6.0 that uses the latest Golang images.

$ docker run maxwo/snmp-notifier:v1.6.0 --version
snmp_notifier, version 1.6.0 (branch: HEAD, revision: a7a4593a9db0b46746403d0d338518111a0aabc8)
  build user:       root@e85efbf57b23
  build date:       20240929-08:25:40
  go version:       go1.23.1
  platform:         linux/arm64
  tags:             netgo

I will update the chart to reference that new version. Until then, you can customize the image.tag value of the current chart to take it into account.

@falk-w
Copy link
Author

falk-w commented Sep 30, 2024

Good point indeed. I just released the v1.6.0 that uses the latest Golang images.

$ docker run maxwo/snmp-notifier:v1.6.0 --version
snmp_notifier, version 1.6.0 (branch: HEAD, revision: a7a4593a9db0b46746403d0d338518111a0aabc8)
  build user:       root@e85efbf57b23
  build date:       20240929-08:25:40
  go version:       go1.23.1
  platform:         linux/arm64
  tags:             netgo

I will update the chart to reference that new version. Until then, you can customize the image.tag value of the current chart to take it into account.

Thanks! FYI: The chart automatically uses the appversion so if the appversion is bumped, it should be sufficient!

@maxwo
Copy link
Owner

maxwo commented Sep 30, 2024

Yes, but I was willing to add another feature in the chart. I will do a simple PR just for the appVersion though.

@maxwo
Copy link
Owner

maxwo commented Oct 5, 2024

Helm chart PR: prometheus-community/helm-charts#4893

Needs to be merged, but that ends that issue. Thank you

@maxwo maxwo closed this as completed Oct 5, 2024
@maxwo
Copy link
Owner

maxwo commented Oct 18, 2024

FYI, Helm Chart PR has been merged.

@falk-w
Copy link
Author

falk-w commented Oct 21, 2024

FYI, Helm Chart PR has been merged.

Thanks! I was also monitoring this, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants