Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snakePipes 3.0.0 logging #1051

Open
katsikora opened this issue Sep 6, 2024 · 4 comments
Open

snakePipes 3.0.0 logging #1051

katsikora opened this issue Sep 6, 2024 · 4 comments

Comments

@katsikora
Copy link
Contributor

I get no logs, and the numbered run logs are empty.

@WardDeb
Copy link
Member

WardDeb commented Sep 9, 2024

Hi Katarzyna,

Can you add a reproducible example ?
I can then have a look.

@katsikora
Copy link
Contributor Author

Hi Ward,

I finally got the logs but only after the run has exit... Is this expected?

Best,

Katarzyna

@WardDeb
Copy link
Member

WardDeb commented Sep 11, 2024

Yea, I got rid of it when simplifying runAndCleanup. I figured real time stdout/stderr in console is enough information, and we don't need to flush the buffer on every line. In case you want this back one could just add f.flush() again after writing a line:

f.write(stdout.decode('utf-8'))

@katsikora
Copy link
Contributor Author

Hmmm, interesting, so the buffer must be quite large.
Perhaps indeed flushing after each line would be useful. I'd prefer to have the log available as soon as possible if I'm working on fixing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants