Skip to content

Commit 064bd76

Browse files
committed
Remove exception
1 parent 3cac953 commit 064bd76

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

tests/test_webservice.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import os
44
from io import open
55
from typing import Type, Union
6-
import pytest_httpserver
6+
from pytest_httpserver import HTTPServer
77
import pytest
88

99
from minfraud.errors import (
@@ -24,17 +24,19 @@ class BaseTest(unittest.TestCase):
2424
client_class: Union[Type[AsyncClient], Type[Client]] = Client
2525

2626
@pytest.fixture(autouse=True)
27-
def setup_httpserver(self, httpserver: pytest_httpserver.HTTPServer):
27+
def setup_httpserver(self, httpserver: HTTPServer):
2828
self.httpserver = httpserver
2929

3030
def setUp(self):
3131
self.client = self.client_class(42, "abcdef123456")
32-
self.client._base_uri = self.httpserver.url_for("/minfraud/v2.0")
33-
self.client._factors_uri = self.httpserver.url_for("/minfraud/v2.0/factors")
34-
32+
self.client._base_uri = self.httpserver.url_for("/minfraud/v2.0")
33+
self.client._factors_uri = self.httpserver.url_for("/minfraud/v2.0/factors")
34+
3535
self.client._insights_uri = self.httpserver.url_for("/minfraud/v2.0/insights")
3636
self.client._score_uri = self.httpserver.url_for("/minfraud/v2.0/score")
37-
self.client._report_uri = self.httpserver.url_for("/minfraud/v2.0/transactions/report")
37+
self.client._report_uri = self.httpserver.url_for(
38+
"/minfraud/v2.0/transactions/report"
39+
)
3840
self.base_uri = self.client._base_uri
3941

4042
test_dir = os.path.join(os.path.dirname(__file__), "data")
@@ -217,17 +219,14 @@ def test_200_with_email_hashing(self):
217219
def custom_handler(r):
218220
nonlocal last
219221
last = r
220-
return "hello world"
222+
return '{"status": 204}'
221223

222224
self.httpserver.expect_request(uri, method="POST").respond_with_handler(
223225
custom_handler
224226
)
225227

226228
request = {"email": {"address": "Test+ignore@maxmind.com"}}
227-
try:
228-
self.run_client(getattr(self.client, self.type)(request, hash_email=True))
229-
except Exception as e:
230-
pass
229+
self.run_client(getattr(self.client, self.type)(request, hash_email=True))
231230

232231
self.assertEqual(
233232
{
@@ -245,11 +244,11 @@ def test_200_with_locales(self):
245244
locales = ("fr",)
246245
client = self.client_class(42, "abcdef123456", locales=locales)
247246
client._base_uri = self.httpserver.url_for("/minfraud/v2.0")
248-
client._factors_uri = self.httpserver.url_for("/minfraud/v2.0/factors")
249-
client._insights_uri = self.httpserver.url_for("/minfraud/v2.0/insights")
247+
client._factors_uri = self.httpserver.url_for("/minfraud/v2.0/factors")
248+
client._insights_uri = self.httpserver.url_for("/minfraud/v2.0/insights")
250249
client._score_uri = self.httpserver.url_for("/minfraud/v2.0/score")
251-
client._report_uri = (
252-
self.httpserver.url_for("minfraud/v2.0/transactions/report")
250+
client._report_uri = self.httpserver.url_for(
251+
"minfraud/v2.0/transactions/report"
253252
)
254253
model = self.create_success(client=client)
255254
response = json.loads(self.response)

0 commit comments

Comments
 (0)