Skip to content

Commit 396a279

Browse files
committed
Lowercase what fields we can for now.
1 parent 440ec9e commit 396a279

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

instana/recorder.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ def build_sdk_span(self, span):
9898
logs=self.collect_logs(span))
9999

100100
sdk_data = sd.SDKData(
101-
Name=span.operation_name,
102-
Custom=custom_data
101+
name=span.operation_name,
102+
custom=custom_data
103103
)
104104

105105
if "span.kind" in span.tags:
@@ -110,7 +110,6 @@ def build_sdk_span(self, span):
110110
else:
111111
sdk_data.Type = "local"
112112

113-
114113
data = sd.Data(service=self.get_service_name(span),
115114
sdk=sdk_data)
116115

instana/span.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ def __init__(self, **kwds):
4343
self.__dict__.update(kwds)
4444

4545
class SDKData(object):
46-
Name = None
46+
name = None
4747
Type = None
48-
Arguments = None
48+
arguments = None
4949
Return = None
50-
Custom = None
50+
custom = None
5151

5252
def __init__(self, **kwds):
5353
self.__dict__.update(kwds)

tests/test_ot_span.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,9 @@ def test_sdk_spans(self):
8383
assert sdk_span.data
8484
assert sdk_span.data.sdk
8585
assert_equals('entry', sdk_span.data.sdk.Type)
86-
assert sdk_span.data.sdk.Custom
87-
assert sdk_span.data.sdk.Custom.tags
86+
assert_equals('custom_sdk_span', sdk_span.data.sdk.name)
87+
assert sdk_span.data.sdk.custom
88+
assert sdk_span.data.sdk.custom.tags
8889

8990
def test_span_kind(self):
9091
recorder = opentracing.global_tracer.recorder

0 commit comments

Comments
 (0)