Skip to content

Commit 043752a

Browse files
committed
Refactored CI jobs for tests so they also run on macos-14 (ARM CPU)
Unified handling of OS and Python versions. Removed complexity: I did not see any usage of coverage reports in pipelines, so I removed it. I do not see any need to use the make file for running tests.
1 parent ed3b9fa commit 043752a

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/ci-community.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414

1515
jobs:
1616
track-modules:
17-
runs-on: ubuntu-latest
17+
runs-on: ubuntu-22.04
1818
steps:
1919
- name: Checkout contents
2020
uses: actions/checkout@v4
@@ -38,14 +38,14 @@ jobs:
3838
outputs:
3939
changed_modules: ${{ steps.compute-changes.outputs.computed_modules }}
4040
test:
41-
needs: [track-modules]
41+
needs: track-modules
4242
if: ${{ needs.track-modules.outputs.changed_modules != '[]' }}
4343
strategy:
4444
fail-fast: false
4545
matrix:
46-
python-version: [ "3.11" ]
47-
module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }}
48-
runs-on: ubuntu-latest
46+
os: [ "ubuntu-22.04", "macos-14" ]
47+
python-version: ["3.9", "3.10", "3.11", "3.12"]
48+
runs-on: ${{ matrix.os }}
4949
steps:
5050
- name: Checkout contents
5151
uses: actions/checkout@v4
@@ -54,6 +54,6 @@ jobs:
5454
with:
5555
python-version: ${{ matrix.python-version }}
5656
- name: Install Python dependencies
57-
run: poetry install -E ${{ matrix.module }}
57+
run: poetry install --all-extras
5858
- name: Run tests
59-
run: make modules/${{ matrix.module }}/tests
59+
run: poetry run pytest -v modules

.github/workflows/ci-core.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
os: [ ubuntu ]
16+
os: [ "ubuntu-22.04", "macos-14" ]
1717
python-version: ["3.9", "3.10", "3.11", "3.12"]
18-
runs-on: ${{ matrix.os }}-latest
18+
runs-on: ${{ matrix.os }}
1919
steps:
2020
- uses: actions/checkout@v4
2121
- name: Set up Python
@@ -27,4 +27,4 @@ jobs:
2727
- name: Run twine check
2828
run: poetry build && poetry run twine check dist/*.tar.gz
2929
- name: Run tests
30-
run: make core/tests
30+
run: poetry run pytest -v core

0 commit comments

Comments
 (0)