Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the .gitignore and .mdbookignore files #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Bergmann89
Copy link

If you use the root directory of the repository as source directory for mdbook, mdbook-pandoc will copy all files, including the book directory where the output is rendered to, to the output directory. This result in an infinite loop until the disk is full, or the paths are too long to be handled.

mdbook has a not yet merged PR to have a separate .mdbookignore file similar to .gitignore (see here).

This pull requests implements support for the .mdbookignore and the .gitignore file.

@max-heller
Copy link
Owner

Thanks for the review! I'll wait for the mdbook PR to be merged before reviewing closely.

Can we use the recursive iterator provided by ignore instead of having a recursive copy function?

@Bergmann89
Copy link
Author

Thanks for the review! I'll wait for the mdbook PR to be merged before reviewing closely.

Alright 👍

Can we use the recursive iterator provided by ignore instead of having a recursive copy function?

Sure. I will add this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants