fix: Stale SimpleMissionItem param metadata causing sliders with -DBL_MAX min / odd values#14492
fix: Stale SimpleMissionItem param metadata causing sliders with -DBL_MAX min / odd values#14492jnomikos wants to merge 2 commits into
Conversation
…_MAX minimums / odd values. When facts rebuild, clear param metadata fully to prevent stale min / max from creating sliders on mission items without user defined values with weird min / max.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a helper to reset parameter FactMetaData before rebuilding mission item facts, ensuring stale metadata doesn’t linger across rebuilds.
Changes:
- Introduced
_clearParamMetaData()inSimpleMissionItem - Invoked
_clearParamMetaData()at the start of_rebuildFacts()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MissionManager/SimpleMissionItem.h | Declares new helper for clearing param metadata |
| src/MissionManager/SimpleMissionItem.cc | Implements helper and calls it before rebuilding facts |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14492 +/- ##
==========================================
+ Coverage 25.47% 28.76% +3.29%
==========================================
Files 769 767 -2
Lines 65912 66321 +409
Branches 30495 30593 +98
==========================================
+ Hits 16788 19080 +2292
+ Misses 37285 34250 -3035
- Partials 11839 12991 +1152
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 272 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 46 failed, 7 skipped. Test Resultslinux-coverage: 90 passed, 0 skipped Code CoverageCoverage: 62.8% No baseline available for comparison Artifact Sizes
Updated: 2026-06-08 01:35:36 UTC • Commit: 281dbed • Triggered by: Linux |
Description
When creating a waypoint and then switching the type to
GIMBAL_MANAGER_PITCHYAW,GRIPPER_ACTION,CONTROL_MOUNT,GUIDED_LIMITS, etc. There will be sliders which show-DBL_MAXvalue for minimum, or-Infinity,Infinityfor min and max. This is because stale data from the previous mission item persists when selecting the new one and ends up as those slider min / max. Thus, the behavior depends on what waypoint you switch from.To fix this (and avoid any issues like this appearing again), I added a new method which clears param metadata in simple mission item, and it will clear the metadata whenever
_rebuildFactsis called.Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).